[merge] small LockableFiles cleanups
John Arbash Meinel
john at arbash-meinel.com
Tue Nov 18 17:00:54 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Martin Pool wrote:
I don't quite understand the reason to rename a _foo method to __foo
with identical functionality. I assume you are just trying to hide its
visibility? Who was trying to call it?
It seems like having the test suite actually ensure the escaping is done
correctly is valuable, so I'm not sure why you feel like you need to
hide it. (I presume an child class was getting it accidentally?)
I'll note that there is only 1 caller of __escape that is not already a
deprecated function, which is __init__().
I'll also note that I think getting rid of escape entirely wouldn't
actually break any functionality. At least for bzr, possibly not so for
plugins. But I'm pretty sure that all the control file names are simple
ascii that doesn't need escaping.
In the end, I guess I just would have liked you to explain what you were
doing, rather than having to infer it from the patch. The change seems
okay, though it would be nice to actually be able to deprecate __escape.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar