[MERGE] Give full control over plugins to bzrlib clients

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Here is a new version of my patch that adds tests and makes no changes
to colordiff handling.

Robert Collins wrote:
> On Thu, 2008-11-13 at 15:33 -0500, Aaron Bentley wrote:
> I think vincent's change was an improvement, because it allows different
> plugins to set the colour code.

I still think this is wrong, and don't plan to use it, especially since
it was implemented over my objections.

But I've removed it from this patch so we can deal with it separately.

>> There are no tests, because plugin machinery is hard to test.
> 
> There are plenty of existing tests; I'm happy to give pointers on how to
> extend them; I acknowledge some parts (particularly the 'what happens on
> default bzrlib load') may be tricky to test and am not going to ask you
> to increase the test coverage; however decreasing the test coverage in
> this area is not a good thing, because it will let the plugin machinery
> become buggy, and harder to test, over time.

I have increased the test coverage.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkfJ+kACgkQ0F+nu1YWqI3jAQCfSGppS8TDR4kyIarMIIQ4uTSt
GkUAn2olZ0FOvThadfoqKoopbkW4zK/J
=mWxF
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test-plugins.patch
Type: text/x-diff
Size: 13446 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081115/70e44687/attachment.bin