[MERGE][#294479] Make InterPackRepo set the packer cache size even when there is stacking.
Andrew Bennetts
andrew.bennetts at canonical.com
Wed Nov 12 23:31:39 GMT 2008
This is a bit ugly, but it's the least intrusive fix I could see. It would
be nice if stacked pack repositories didn't hit a completely different (and
apparently buggier and slower) code path than non-stacked pack repositories.
But anyway, this patch fixes the problem that pushing to a stacked
repository will write to the new pack file one record at a time, i.e. lots
of ~500 byte writes rather than a few 1MB writes. Because our writes over a
network collection are synchronous this patch greatly reduces the number of
roundtrips for pushing to a remote stacked repository.
In the bug report Robert suggested that it might be cleaner to just default
the NewPack._cache_limit to 1MB rather than 0. Unfortunately some code
expects to be able to read arbitrary bytes from a pack that is being
created, so that approach breaks things.
-Andrew.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: newpack-cache-limit-3835.patch
Type: text/x-diff
Size: 4800 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081113/9ed0b357/attachment.bin
More information about the bazaar
mailing list