[MERGE] Fix #296620 by allowing plugins instead of requiring them.

Aaron Bentley aaron at aaronbentley.com
Tue Nov 11 22:40:06 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Tue, 2008-11-11 at 11:16 -0500, Aaron Bentley wrote:
>> So I can't see why bzrlib/__init__.py:111 is necessary.  Can you shed
>> any light, Robert?
> 
> It makes the plugin path available to users of bzrlib that don't want to
> load all plugins;

I am not sure that we have any of those.

> so you can import a plugin without loading them all -
> and that one can get its dependencies too.

It does not enable that, it only means that the client doesn't have to
do the function call.

> It also means you don't have
> to call a special magic method to let this work in your code.

I think that performing this at import time is more magic than a method
would be.  I certainly believed that it was necessary to run
load_plugins before using any, and I did not expect merely importing
bzrlib to have this effect.

I don't think we have any clients who wish to import single plugins, but
I know that I would like Bazaar to be able to disable plugins completely.

Since this is only a convenience for putative one-plugin clients, but a
necessity for a robust "bzr --no-plugins", I'll see about a patch.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkaCcYACgkQ0F+nu1YWqI3WIQCeKLZH/YCbfqaJfJrHRetwuK1S
oacAn2dRx3y9pl8cwlyhbx5Quyk6Z2Zj
=IhkN
-----END PGP SIGNATURE-----



More information about the bazaar mailing list