[MERGE] Fix #296620 by allowing plugins instead of requiring them.

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> It's misleading to say "allowing plugins instead of requiring them."
> Bzrtools is not required for the shelf UI to run.
> 
> The bug, IMHO, is that --no-plugins does not prevent plugins from loading.

This is caused by bzrlib/__init__.py:111
# allow bzrlib plugins to be imported.
import bzrlib.plugin
bzrlib.plugin.set_plugins_path()

Robert introduced this change so that plugins could import one another,
but it seems like they already should be able to.  commands.run_bzr
invokes load_plugins, and that invokes set_plugins_path.

Before plugins are loaded, they can't attempt to import one another.
Before load_plugins actually loads the plugins, it calls set_plugins_path.
Finally, it loads the plugins.

So I can't see why bzrlib/__init__.py:111 is necessary.  Can you shed
any light, Robert?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkZr9sACgkQ0F+nu1YWqI3GagCfTrKk6jUrZQIqG8OUue5zY1vi
8swAnR4R1t50soWhBF50b331/cDMfA7z
=Wq0g
-----END PGP SIGNATURE-----