[MERGE] selftest errors if modules said to have doctests don't have them

[Martin Pool]

On Tue, Nov 11, 2008 at 11:23 AM, John Arbash Meinel
<john at arbash-meinel.com> wrote:

> I agree, but I can't approve code I don't see :)

Ye of little faith... :)

The modules removed from the list turn out not to have doctests.

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: mbp at sourcefrog.net-20081111011928-g79d2s0eqx8zrwnh
# target_branch: http://sourcefrog.net/bzr/trunk
# testament_sha1: e9e51576d88c56c3fac68fbb779aceafaa2e86ba
# timestamp: 2008-11-11 11:24:01 +1000
# source_branch: http://sourcefrog.net/bzr/branchbuilder
# base_revision_id: pqm at pqm.ubuntu.com-20081107225426-gezbao014attrca8
#
# Begin patch
=== modified file 'NEWS'
--- NEWS	2008-11-07 18:10:32 +0000
+++ NEWS	2008-11-11 01:19:28 +0000
@@ -27,11 +27,15 @@
   DOCUMENTATION:

   API CHANGES:
+
     * Transport implementations must provide copy_tree_to_transport.  A default
       implementation is provided for Transport subclasses.

   TESTING:

+    * ``bzr selftest`` now fails if no doctests are found in a module
+      that's expected to have them.  (Martin Pool)
+
   INTERNALS:



=== modified file 'bzrlib/tests/__init__.py'
--- bzrlib/tests/__init__.py	2008-11-03 19:01:14 +0000
+++ bzrlib/tests/__init__.py	2008-11-11 01:19:28 +0000
@@ -2953,14 +2953,12 @@

     modules_to_doctest = [
         'bzrlib',
-        'bzrlib.errors',
         'bzrlib.export',
         'bzrlib.inventory',
         'bzrlib.iterablefile',
         'bzrlib.lockdir',
         'bzrlib.merge3',
         'bzrlib.option',
-        'bzrlib.store',
         'bzrlib.symbol_versioning',
         'bzrlib.tests',
         'bzrlib.timestamp',
@@ -2976,6 +2974,8 @@
         except ValueError, e:
             print '**failed to get doctest for: %s\n%s' % (mod, e)
             raise
+        if len(doc_suite._tests) == 0:
+            raise errors.BzrError("no doctests found in %s" % (mod,))
         suite.addTest(doc_suite)

     default_encoding = sys.getdefaultencoding()

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWZVQV2kAAkPfgFRQU/f//1ID
SID////wUATMXgAVKQoNISSKepok/1U/QSfhPRJ5TKbJNP0UfpQAaB6hzAATJgATCYJhDAEYAEom
iNTUeptNNEbRNBo0ABib1TTIAcwAEyYAEwmCYQwBGABJICDII0yJMmmTTRlHhT1GTQepoyQ1gMmj
J0rjsgzvr0JYysxdfmUUy7Gumjfkgi/K4C4VM5npVReBHhl4Za4TWwT1MwoqqqE+fUG6ERqWZUqX
Ao+FbNidXEeNh3zMu5ePGrXWd9uNln7B85Ox7pNyyVxF0vp6DTswUCkR9fFf8sFGGmGtoZyNx2LI
gOtpeg5MrypmlS9zHft1Uc/ZXQUkfNDAbjibK4gMtYT1jh0Xn+r1Qf3gWrgqa2WnzRCKFm2DNlkI
Jhz8AOxaHX4+46g9SiHGBCr+Q8UULG5RIRiMPsPYd3sAmBb5Ms2Kb3NhWdYOCBe4CCGAYCIicsjC
UMd/1Yh3J5aq3FkDx+Rn8LyudQIVUjHW0oTwyHYl/0EDiUrxw4vU5klmWg55DQCJNBWCMS80AjdS
4feUsLwsGLCWkhm2KuIXkJFYRHG9VJszPYZMxjVPkXh+cCxMTUSRmQwO90qUfiSHDL5GHDj4kTgp
Gh22ETUcxzVKE7TYyKEB8sic+NjlpWuUn0GiRldInqSUy/EH8aRuGW3IseZkDIlIsCAWYlxPtAoE
DEwLETwcOdDO6oGdp2QWaFAkYjplxArOgxnzFTlyd9wJXljtWAzpFJio7galgEiu5Wtsb94TCCgr
kR7ThiXMl0Y5R/lrmMw6Z9jHkORtt+y9vB8ziZnveaFFBhBmBj+ve71WFvo1WwPsrV5740xT3QZD
8vKO5l15/N9XNlFuLT0HcMZ13dfE/RaWXhm1kkc3cH++pUPMFhTFJwfs31sVJy58tRsIEsCiRUaZ
LCo8SomNSDd5dvkurvEcTcby6h4qB6dC4jy96Diam7parvgjpuvUnNBz5GqwDwNRpM4QBs4omQ1j
ljx3LDSGhQ68HFLzg8kXlG8caDHpDLaTHgU+tcTbEnacyItIG+8uOUbd/oawQbItKQzNk4VgFNzX
28ioXe03kkMwaIL0E3okb1LSxaO3GZqbDy/ge495YuRevmdZYa6ORig3I8OlB3AcPek5ft9rhaMN
zi5qp97y3ETvYWQ8xQP8tNy79hTkRGG80X2/LZ8ckFnYgwp3wK49pC6dGl+wzBY9hTu1liNL4Vz5
0Zeq6ucti8/oegMUTcqGt/NmT6FJESrCIpiJmRQ/zQO6QPc6eDWiewrE5bc5sUXSGWjDIMTnFbFg
gMDHd+BwrUXpx3vVsDoQVp3oMzly4hFeNwU0+i2mW2jcymLiBx4XvBzkffI0WCCfWyVO3eYMn0le
rdUFoQwDZfWwsGJDnGQDlafhp9kvvCHkBB4y5CrLK2xX2hfSZAUiGNAoAggoPdXvVQZnAMeGcC7p
9oSHu668kOVcQu/DjbUcMUHFEOVyZwMQYKVTk8ivTqXZ1W+HxgbsCSk5BRUXBA9/xwAlq7wKYiQv
dCMMy+1D0sRbuz0A/xdyRThQkJVQV2k=



-- 
Martin <http://launchpad.net/~mbp/>