Small patch for CHK branch to fix some tests

Martin Pool mbp at canonical.com
Mon Nov 10 07:08:01 GMT 2008


On Mon, Nov 10, 2008 at 5:01 PM, Robert Collins
<robertc at robertcollins.net> wrote:
> So, I think this would be better as:
>
> -        deleted_ids = set(self.basis_inv._byid.keys()) - \
> -            set(self.builder.new_inventory._byid.keys())
> +        if isinstance(self.basis_inv, Inventory):
>            deleted_ids = set(self.basis_inv._byid.keys()) - \
>                set(self.builder.new_inventory._byid.keys())
> +        else:
>             deleted_ids = set(self.basis_inv) - \
>                 set(self.builder.new_inventory)
>
> because of previous performance testing in commit.

I don't think it can make a difference except two method calls per
commit, as Inventory.__iter__ just returns iter(self._byid).

-- 
Martin <http://launchpad.net/~mbp/>



More information about the bazaar mailing list