Bound branch (lightweight checkout) now asks for remote password before doing commit

[Marius Kruger]

2008/11/7 Nicholas Allen <nick.allen at onlinehome.de>

> Hi,
>
> I have a bound branch to a remote location that is password protected.
> When I run bzr commit command the password is asked for immediately.
> Even before I am asked for commit message. This only started happenning
> in 1.9 after I upgraded bzr on Ubuntu 8.10.
>
> This means I am now asked for the password twice. Once before entering
> the commit message and once after entering it and before the data is
> sent of the network.


I was not able to reproduce it asking for the password twice, using bzr.dev
and and the commandline commit. Are you experiencing this using a GUI,
or a pluggin changing commit behaviour?


It does ask for the password before asking for the message now.
MutableTree.commit determines the nick to be stored as part of the revision
properties
and passes it to Commit.commit which does a callback to determine the
message.

Maybe it would be possible to read the nick after obtaining the message and
pass it to CommitBuilder.commit
I'm not sure if some GUI's or plugins rely on it being available earlier to
perhaps show it to the user while obtaining the message. So maybe only
populating it later would be an API break.

regards
marius
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20081109/da3bcc51/attachment.htm