[MERGE][1.9][bug 293054] Build the ssl socket in a python-2.6 compatible way *and* make the test suite passes again on OSX with python-2.6

John Arbash Meinel john at arbash-meinel.com
Fri Nov 7 21:22:00 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
>>>>>> "john" == John Arbash Meinel <john at arbash-meinel.com> writes:
> 
> <snip/>
> 
>     john> +    def _dont_SIGQUIT_on_darwin(self):
>     john> ^- Could we use SIGINT instead of SIGQUIT?
> 
> As Martin said, SIGQUIT is the expected signal and the logical
> one to use. When I said 'Until we find a way to disable that
> intrusive behavior', I was thinking as of OSX specific mean to
> disable the popup (still had to find it, search it even :).
> 
> <snip/>
> 
>     john> So I did a check and on my python2.5 win32 install:
> 
>     john> $ py -c "import errno; print errno.ENOTCONN"
>     john> 10057
> 
>     john> So it seems like doing:
> 
>     john> if not len(e.args) or e.args[0] != errno.ENOTCONN:
>     john>   raise
> 
>     john> is a better way to do it anyway.
> 
> Can we conduct some more tests on the windows side and address
> all the related places in one shot ? We have quite a few places
> where we had to to handle windows specific error codes under hard
> to reproduce circumstances, I don't want to break python-2.4
> support for instance.
> 

ENOTCONN == 10057 on python2.4 as well. I think it is just an issue of
someone not realizing that.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkUsXgACgkQJdeBCYSNAAPpwQCfW5h2eXFuK5XvNeLcxr/0F+dw
R6AAn2eJOcEGiWRG2/kYGvfRN8nG0/Lp
=ZGcn
-----END PGP SIGNATURE-----



More information about the bazaar mailing list