[MERGE][1.9][bug 293054] Build the ssl socket in a python-2.6 compatible way *and* make the test suite passes again on OSX with python-2.6
Martin Pool
mbp at canonical.com
Fri Nov 7 04:56:47 GMT 2008
On Fri, Nov 7, 2008 at 4:44 AM, John Arbash Meinel
<john at arbash-meinel.com> wrote:
>
> + def _dont_SIGQUIT_on_darwin(self):
> ^- Could we use SIGINT instead of SIGQUIT?
SIGINT is generated by Control-C, and that should keep the default
behaviour of interrupting the program. However, we could hook some
other signal like USR2 to go in to the debugger, if that would work
better on OS X. It's a bit less convenient as there's no keypress to
send it.
I think his change for the tests makes sense as a way to have them pass now.
> ^- Can you add a comment like:
> # python 2.4/2.5 don't have ssl and ssl.wrap_socket
> # instead they use httplib.FakeSocket
>
>
> BB:tweak
>
> I would also like to see this land in 1.9, but that is ultimately up to
> Martin.
I'll add that comment and merge it for 1.9final.
--
Martin <http://launchpad.net/~mbp/>
More information about the bazaar
mailing list