[MERGE] Test for bug #272444 (symlinks to Unicode file names)

[Daniel Clemente]

Andrew Bennetts <andrew.bennetts at canonical.com> writes:  >> >  * 
it's odd to have a test that claims to duplicate the testing done 
by >> >    another test.  Is it really a duplicate?  If so, what's 
the value in >> >    having it?  It seems to be a workingtree 
issue rather than a branch >> >    issue, so a 
branch_implementations test does seem to be the wrong >> > 
place.  >> > >>  >>   I did originally write the test with 
self.run_bzr("branch ...") and found that it failed with 
WorkingTreeFormat4, 3 and 2. When I rewrote it with 
set_parent_trees, I found that only WorkingTreeFormat4 failed. So 
Aaron Bentley suggested here [1] to test also sprout() since that 
is what „branch“ uses.  >>  >> [1]: 
http://thread.gmane.org/gmane.comp.version-control.bazaar-ng.general/47300/focus=47848 
> > That seems a bit strange to me, surely it's still the 
workingtree that's > failing?  When I look at the exceptions 
behind the KnownFailures in your > branch_implementations test I 
see that the errors all come from inside > initialize in 
workingtree_4.py, which seems to confirm my intuition.  > > Aaron, 
can you elaborate on why a branch_implementation test for a 
workingtree > problem makes sense to you?  >  Aaron said on IRC: 
It's a substitute for a blackbox test, since blackbox tests can't 
be run against every branch implementation.  It ensures that 
branch works for every implementation of branch.


 Latest version of the patch is at:
http://bundlebuggy.aaronbentley.com/project/bzr/request/<87d4hmvnf1.fsf%40yahoo.com>

 What's missing to get the patch checked in?


Daniel