[MERGE][#248153] Add autopack RPC
John Arbash Meinel
john at arbash-meinel.com
Thu Oct 30 21:24:59 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert Collins wrote:
> On Fri, 2008-10-31 at 02:53 +1100, Andrew Bennetts wrote:
>
>> John Arbash Meinel wrote:
>> ] I agree that returning 'pack-names' seems reasonable, and it shouldn't
>> ] be very hard to factor 'reload_pack_names' one more time to allow
>> ] passing in the name list.
>>
>> Fair enough. It's more than just a list of names, but I've extended the
>> code to do this.
>
> I think this is a bad idea, because its really an internal aspect of the
> repo.
>
> For instance.. in development3, there are more fields. In dev 4 there
> may be less...
>
> -Rob
True, but as long as it is just a "key, value" pair in the index, it
seems to work just fine. Looking at Andrew's code he doesn't do any
direct decoding of what is in the index, just packs it into a tuple and
ships it to the other side.
Another possibility would be to ship the bytes of 'pack-names' back
directly, if you think it is an issue. It does seem like we are wasting
a return value if we don't pass something back from the "autopack" RPC.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkkKJisACgkQJdeBCYSNAAMs0gCbB2oGJ5kzmwmVyhltQy/rS0e1
eK4An2EizDsgpWUSse5inUUly5Nnnw7M
=zZN0
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list