[MERGE] Note number of revisions being bundled
Aaron Bentley
aaron at aaronbentley.com
Thu Oct 30 15:02:31 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
John Arbash Meinel wrote:
> John Arbash Meinel has voted tweak.
> Status is now: Conditionally approved
> Comment:
> note()ing it seems ok. I'm not sure if it is the best way to test for it
> (something like that seems more like a UI test that would be in
> blackbox/* rather than a direct test.)
Before merging, I changed it to a blackbox test.
> I'll also note that if the value is 0, I would still thing a "refusing
> to create an empty bundle" would be a more appropriate result.
I don't agree-- empty merges are obviously wrong, but empty bundles just
mean that the recommended merge involves revisions already present in
the upstream. For example, a reverse merge would legimately have an
empty bundle.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkkJzIcACgkQ0F+nu1YWqI1GlwCeKMpiVABjAhijCovRaB9j1D10
omgAni8I+n60+E5GIG/HNM8Cey5v3kGm
=rTOs
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list