[MERGE] Updates to the 'startup' logging

John Arbash Meinel john at arbash-meinel.com
Thu Oct 30 14:02:08 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Wed, 2008-10-29 at 19:58 -0500, John Arbash Meinel wrote:
>>
>> 1) As part of setting up logging, we call
>> osutils.get_terminal_encoding(), which then logs what encoding we will
>> use. It will log it again when we call it to setup self._outf(). So
>> instead, I switched and suppressed the first one.
> 
> If someone uses bzr as a library, and sets up logging, they will no
> longer get the encoding logged; so this seems faulty.
> 
> 
> -Rob

Well, if there is a traceback they will still get things logged. And if
they ever call 'get_terminal_encoding()' it will be logged. And if they
don't call 'get_terminal_encoding()' then I would guess they aren't
properly writing to the terminal anyway. (user_encoding !=
terminal_encoding).

So I feel a well written user of the library would call it anyway at
some point, and if not then what they are doing is probably not
terminal-encoding critical.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkJvmAACgkQJdeBCYSNAAN7gACaA87BxOOZgyVdnagPNvzITodj
vekAoMUmKl5hW/HPE/TYG8cobeq9zSH7
=dSpY
-----END PGP SIGNATURE-----



More information about the bazaar mailing list