[MERGE] Switch nick too

Martin Pool mbp at canonical.com
Thu Oct 30 02:52:47 GMT 2008


On Wed, Oct 29, 2008 at 11:22 PM, Marius Kruger <amanic at gmail.com> wrote:
> hi,
>
> 2008/10/28 Martin Pool <mbp at canonical.com>
>>
>> Martin Pool has voted approve.
>> Status is now: Approved
>
> thanks for the review!
>
> So can it be merged now? or are we still waiting for another review?

It can be merged now; I just let it sit for a bit in case anyone who'd
previously commented in the fairly long thread had more to say.

> I ask because it keeps on happening to me that a patch is approved according
> to BundleBuggy
> and thus hidden from the other dev's [My Pending] pages
> but since I'm not a core dev others dont merge it

Things can fall in a crack there.  On the other hand, someone who has
reviewed it (like me) does get it listed on their 'Mine' page,
indicating an obligation to do something with it.

>> Is there user documentation of branch nicknames?  It seems like you should
>> update it as a followon patch.
>
> Ok will send that in a followon patch.

Thanks!

-- 
Martin <http://launchpad.net/~mbp/>



More information about the bazaar mailing list