[MERGE] Reliably encode and decode PermissionDenied and ReadError errors from a smart server
John Arbash Meinel
john at arbash-meinel.com
Wed Oct 29 18:54:27 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Andrew Bennetts wrote:
> This patch does two main things:
> * Moves the encoding of PermissionDenied (and ReadError) on the server-side into
> the catch-all for all smart request handlers. This means that any request
> handler that happens to trigger a PermissionDenied will cause a proper
> 'PermissionDenied' response on the wire.
> * Adds client-side decoding of PermissionDenied (and ReadError) to
> It also adds a simple __repr__ to BzrError, just because it makes test failures
> from assertEqual(exc1, exc2) clearer.
I noticed this just recently. I think it was during a pdb session,
though. Anyway, I agree it is nice to have.
> This is a step towards a fix for <https://bugs.launchpad.net/bzr/+bug/278673>,
> and probably some other real but unfiled bugs like it. The rest of the fix will
> be posted shortly as a patch that builds on this one.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar