[MERGE][bug #277484] win32/python2.4 extension fixes

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Vincent Ladeuil пишет:
>> Vincent Ladeuil has voted approve.
>> Status is now: Approved
>> Comment:
>> I think Alexander tested it with MSVC.
> 
> 
> No, Vincent. I did not launch test suite before, because I was busy.
> 
> I'm running selftest now. And I can say that this patch has at least 1 bug.
> I have many tests failed with following message:
> 
> ERROR: blackbox.test_status.CheckoutStatus.test_branch_status
>     attribute 'st_size' of '_walkdirs_win32._Win32Stat' objects is not writable
> 
> ATM I have result:
> 
> [809/14144 in 7m18s, 165 err, 13 fail, 2 missing] blackbox.test_non_ascii.TestNonAscii.test_pull(cp1251)
> 
> So it seems I need to wait hour or so until test suite finished.
> 

Well, it is a pretty foolish bug on my part. The fix is trivial:
=== modified file 'bzrlib/_walkdirs_win32.pyx'
- --- bzrlib/_walkdirs_win32.pyx  2008-10-21 15:38:17 +0000
+++ bzrlib/_walkdirs_win32.pyx  2008-10-23 18:26:16 +0000
- -        statvalue.st_size = _get_size(data)
+        statvalue._st_size = _get_size(data)


It seems I forgot to rebuild the extension and run the test suite properly.

I'll send the trivial fix now.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkAwlsACgkQJdeBCYSNAAMnqQCgjqA9uu+pF90P+HsD15deR7GF
n5QAoJmna7C+7LsQn3nNRJaiRAJW5kMv
=GhY2
-----END PGP SIGNATURE-----