[MERGE] Shelf 2/5: ShelfCreator

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:

...

> 
>> +    def make_shelf_filename(self):
>> +        """Generate a filename for a shelf."""
>> +        transport = self.work_tree.bzrdir.root_transport.clone('.shelf2')
>> +        transport.ensure_base()
>> +        return transport.local_abspath('01')
>> +
>>
>> ^- Is this the responsibility of 'ShelfCreator' or should it be
>> something you request of the WT. It feels like a WT function to me, not
>> to mention I think we decided to put it into .bzr/checkout/shelf/*
>> rather than .shelf2.
> 
> This is the bare minimum required to pass the test suite.  It doesn't
> even produce a unique name, just .shelf2/01 eternally.  It is removed
> when ShelfManager is introduced.  But I can change it anyhow.
> 
> Aaron
> 

Well, it is the difficulty with reviewing layered patches when later
patches change the functionality of earlier patches. Obviously if this
function serves no purpose other than a placeholder, there isn't much
need to do anything to it.

Especially considering you start passing in the file object, rather than
having Shelf know anything about where to put a file.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj9/sIACgkQJdeBCYSNAAPb5gCgmM18BzOo5cH/7gdRSR0qnrth
wKYAoKXyRUf/maXvhUEA8Gmqgb19nWqB
=LzKF
-----END PGP SIGNATURE-----