[MERGE] Shelf 1 / 5: TreeTransform serialization

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
...

> 
> Yet I agree that some direct tests of serialize and deserialize make sense.
> 
> Rather than bytes on disk, they should be testing how the serialization
> API is used.  We already have plenty of tests to ensure that using the
> pack API produces the correct output.
> 
> So deserialize can be exercised by passing in a manually-constructed
> list of records.  serialize can be exercised with an implementation of
> Pack that simply creates a list of records.
> 
> Does that seem right to you?
> 
> Aaron

That seems ok. I think Robert's idea is fine as well, though I'm
thinking we should probably still be asserting the pack format you want
to be using. It just depends how strong you want to guarantee that
different versions of bzr can re-use the shelf contents.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj828MACgkQJdeBCYSNAAMQjQCfTn6OGQEGhp9LsOxbgG9ioNT3
DjsAoKwVEFiY8sRDccHmzw0IeCE/bd39
=zGTT
-----END PGP SIGNATURE-----