[MERGE] dont stacktrace on bad plugin versions
John Arbash Meinel
john at arbash-meinel.com
Thu Oct 16 19:41:05 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Marius Kruger wrote:
> 2008/10/16 John Arbash Meinel <john at arbash-meinel.com
> <mailto:john at arbash-meinel.com>>
>
> > Marius Kruger wrote:
> > [...]
> >> I found code in server.py like:
> >>
> >> try:
> >> ...
> >> except KeyboardInterrupt:
> >> raise
> >> except Exception, e:
> >> trace.log_exception_quietly()
> >>
> >> will that be ok?
> >> is there any others we should ignore?
>
> As we are only worried about what "_format_version" is going to raise, I
> would just trap ValueError, TypeError, and IndexError and let everything
> else pass through.
>
>
> done
>
> I also made non-iteratable and string plugin versions work.
> And added some more tests.
> Hope its ok.
>
> regards
> marius
>
>
BB:approve
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkj3isEACgkQJdeBCYSNAAP/DACdEod5IqJf2V1p4qx5NrDOayGH
LdcAmgPMdMz/ZjU6+XugEZsvihOaUbkh
=Bgc6
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list