[MERGE] dont stacktrace on bad plugin versions

[Marius Kruger]

2008/10/16 John Arbash Meinel <john at arbash-meinel.com>

> > Marius Kruger wrote:
> > [...]
> >> I found code in server.py like:
> >>
> >>        try:
> >>             ...
> >>         except KeyboardInterrupt:
> >>             raise
> >>         except Exception, e:
> >>             trace.log_exception_quietly()
> >>
> >> will that be ok?
> >> is there any others we should ignore?
>
> As we are only worried about what "_format_version" is going to raise, I
> would just trap ValueError, TypeError, and IndexError and let everything
> else pass through.


done

I also made non-iteratable and string plugin versions work.
And added some more tests.
Hope its ok.

regards
marius
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20081016/23f7bb1b/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr.bad_plugin_versions3.patch
Type: text/x-patch
Size: 10099 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081016/23f7bb1b/attachment.bin