[MERGE] 'bzr dump-btree'

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Thu, 2008-10-09 at 11:57 +1100, Martin Pool wrote:
>> On Thu, Oct 9, 2008 at 11:10 AM, John Arbash Meinel
>> <john at arbash-meinel.com> wrote:
>>> I'd like to have something to debug any btree index as well. I can add
>>> *another* command if you would like. With btree, I miss being able to
>>> see the contents from time to time (when investigating bugs, etc.), so I
>>> think this is still useful as is.
>>>
>>> So could you clarify what you want me to do? Would you like me to add
>>> something *additional* or you don't like this command at all, etc.
>> I think this is one of those cases where we can make our review cycles
>> smaller in scope and faster to execute.  In other words, if John's
>> patch is useful to him now, let's just merge it, without causing
>> uncertainty or delay by discussing what might be nice in the future.
>> We can always add more later.
> 
> Sure; I hadn't looked at the code, I was talking about the conceptual
> desirability of this.
> 
> To put a reviewers hat on, I don't think a btree specific command *is*
> desirable.
> 
> Anyhow, I've given my suggestions.
> 
> -Rob

I'm going to go ahead and merge this as is, because I've now used it on
more than 3 occasions. I think your outline of a "bzr dump-index"
command is very nice, and if we can find the time to write it, we can
just nuke the 'dump-btree' command. It is hidden, and is meant as a
developer only tool anyway.

My only concern with your version, is that it doesn't support
tab-completion. Right now I don't have to type those long md5sums
because I can just tab complete, or copy & paste. With your proposal,
c&p doesn't work because you have to split up the path based on kind, etc.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjvpDAACgkQJdeBCYSNAAMAqwCgtw31jqxHHrpwE3dxh7KQBy2X
QbcAoLD0u7K+4BVHamdiK6gSfO58GJT+
=7Efw
-----END PGP SIGNATURE-----