Interpret .bzr/branch/location relative to checkout root

[Colin D Bennett]

On Wed, 08 Oct 2008 13:29:03 -0500
John Arbash Meinel <john at arbash-meinel.com> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Colin D Bennett wrote:
> ...
> 
> > So bzr is interpreting the '.bzr/branch/location' contents relative
> > to the current working directory.  I propose that it should
> > interpret the 'location' of the checkout's bound branch relative to
> > the checkout root.  It should not behave differently depending on
> > what subdirectory depth you are at below the checkout.
> > 
> > Am I missing something?  Is the current behavior intended, and
> > would a patch be welcome to make it relative to the checkout root?
> > 
> > Regards,
> > Colin
> 
> So the contents of 'location' are supposed to be absolute paths. It
> happens to work sometimes if you force it to a relative path, but as
> you noticed, it is a bit more accidental than on purpose.
> 
> Personally, I think it would be good to do a relative path when
> possible, like we do for "get_parent". My only concern is about
> compatibility with older clients, as they won't be able to understand
> a checkout with a relative location very well.
> 
> Perhaps we can bring in the functionality, and not make it default, so
> that people can do it themselves, and then on the next WT release, we
> make it the default behavior.
> 
> John
> =:->

That sounds ideal to me!

Perhaps we could even have a setting in ~/.bzr/locations.conf that
could say:

  "any checkouts from repositories under /home/cdb/gamma.mnt should
   write relative paths in 'location' if possible",

but just making it possible for people to manually edit 'location' to
make the path relative would fine, since at least it would be
*possible* for us users to make it work.

Thanks,
Colin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081008/a4e5649d/attachment.pgp