status and commit uses different algorithms to find changes

Alexander Belchenko bialix at ukr.net
Wed Oct 8 14:38:40 BST 2008


John Arbash Meinel пишет:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Alexander Belchenko wrote:
>> Hi John,
>>
>> Once not so while ago we talked in IRC and I said that it's to sad that
>> commit don't use
>> working tree's iter_changes() method to collect changes for commit. As I
>> remember you
>> said that it's not true and in reality commit uses it.
> 
> I wouldn't have said that, as I know commit does *not* use
> iter_changes().

So I misunderstood you then.

Why this question arised: I've discussed with you problem in my branch
where I have commit with no changes in some files. So `bzr log FILE`
show wrong log.
I think it was because I've used during that commit my rejected patch
for end-of-lines support.

And I don't know does this problem affect Ian's filtering work too or not.
In my case it seems like commit schedule file to commit even before eol filter
starting to work.

And it's too sad to see what's going on with Ian's work for filtering content.
I.e. nothing. It's just hanging indefinitely again.
Six months ago Ian started his work. It's a shame to see this end.

> It can't, because of issues when there are more than one
> parent. We have to compare against both sides, *and* pay attention to
> last-modified revisions, while iter_changes() does not.

OK. I was wrong but anyway my point remains.

Thank you for explanation.




More information about the bazaar mailing list