[MERGE/RFC] Use True/False objects for iter_changes

John Arbash Meinel john at arbash-meinel.com
Tue Oct 7 22:25:52 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

It seems that bzr-gtk copied the same if/else block that Robert fixed
when he changed the pyrex iter_changes to return 1/0 instead of True/False.

Which means that bzr-gtk breaks if you use the compiled extensions. We
can certainly update bzr-gtk, but we can also play nicely with existing
versions.

For pyrex 0.9.8.5 this should be reasonably fast, as it accesses the
Py_True object directly (rather than looking it up by name). I don't
know if that is true for older versions.

Thoughts?

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjr0+AACgkQJdeBCYSNAAMHfgCglx5cMluAXDmWKS8sn4DOhvwC
P2UAn05MBXzUQZlF8+VCFjAAFayQZPz4
=LgGx
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: use_True_False.diff
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20081007/67d5dacb/attachment.diff 


More information about the bazaar mailing list