[MERGE] Test for bug #272444 (symlinks to Unicode file names)

[Daniel Clemente]

Hi,

Aaron Bentley <aaron at aaronbentley.com> writes:

>>   I based the new changes on the old patch, but rather manually (since I had to apply to bundle at other computer). I don't know if Bundle Buggy will detect that this one supersedes the old one.
>
> You can always just "bzr pull
> 'http://bundlebuggy.aaronbentley.com/download_patch/%3C871vzcdom9.fsf@yahoo.com%3E'".
>
> I think you're confusing merge directives with bundles, but both bundles
> and merge directives can be merged or pulled.
>
   And there's even „bzr merge --pull“ to twist the concepts more. :-)
   I discovered the right command for what I wanted to do: bzr pull --overwrite my_patch
   I hope this time Bundle Buggy will understand my patch.
  

>>   I'm not sure I have used bzrlib's API correctly. Please improve it or give some advice.
>
> I think it's okay.  It seems a little strange to set the parents to
> [first_revision, second_revision], but this can actually happen when
> merging, so that's fine.
>

   I didn't understand it correctly. I thought that set_parent_ids(...) was to specify the parents of the tree plus the parents of those parents and of those parents etc. Now I know that it's just for the parents of this working tree.
   I simplified the patch and wrote better names. I think it is clearer now.


>>   The old test (with self.run_bzr) failed with WorkingTreeFormat4, WorkingTreeFormat3 and WorkingTreeFormat2. This one only fails with WorkingTreeFormat4 only. Maybe it is testing too few things.
>
> Your original test was a test of "bzr branch", and this is implemented
> using BzrDir.sprout.  It would be reasonable to test BzrDir.sprout as well.
>

   I wrote a test for that. Below I attach the output I got.

   Even if you approved the former patch, could you use this one instead?


   Thanks,
Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_272444_v4b.patch
Type: text/x-diff
Size: 7154 bytes
Desc: fourth version of the patch
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081006/d1daf813/attachment.bin