[shell_hooks/MERGE] make it possible to set the shell hooks globally.

[Marius Kruger]

2008/10/1 Jelmer Vernooij <jelmer at samba.org>

> Hi Marius,
>
> On Fri, 2008-09-12 at 16:18 +0200, Marius Kruger wrote:
> >
> >
> > 2008/9/12 Jelmer Vernooij <jelmer at samba.org>
> >         Am Freitag, den 12.09.2008, 00:53 +0200 schrieb Marius Kruger:
> >         > hi,
> >         > another small patch which makes it possible to set the shell
> >         hooks
> >         > globally.
> >         > I dont know what the performance impact of this will be, but
> >         I really
> >         > need this feature,
> >         > so hope youre ok with it.
> >
> >         This merge request doesn't work for me - it seems to depend on
> >         a
> >         revision I don't have. I've merged the other patch.
> >
> > sorry for that, I actually wrote that on the same branch as the other
> > patch,
> > so since you merged the other one, this one should work fine.
> >
> > I thought that if its an issue for you I can convert it for you.
> >
> > BTW, will it also be ok with you if I add support for locations.conf?
> In that case, any reason for not using Branch.get_config() ? That will
> automatically take care of reading all those three locations under the
> hood.


1) I didn't know about it.
2) It doesn't accept the options in the [hooks] section, so we would still
need
    to check for that if you'd like to be backwards compatible.

Another thing I figured out while testing if youre solution would work,
is that behind a smart server, locations.conf does not work like (I)
expected:
it tries to match urls like: chroot--1211723252:///bazaartest/b/
in stead of /var/lib/gforge/bzrroot/bazaartest/b/
So location based conf does not seem to be a option when running
behind a smart server (bzr+http://)  ATM.
(This might be fixable after https://bugs.launchpad.net/bugs/270267 is
fixed)

-- 
regards
Marius
<><
http://amanica.blogspot.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20081003/6d8cc48b/attachment.htm