[MERGE][bug 276868] Blacklist pyrex

Matt Nordhoff mnordhoff at mattnordhoff.com
Thu Oct 2 00:26:25 BST 2008

John Arbash Meinel wrote:
> Matt Nordhoff wrote:
>> John Arbash Meinel wrote:
>>> It seems that pyrex fails to properly compile the new iter_changes
>>> code that Robert wrote. The code it generates re-uses a "local" pointer and
>>> calls "PY_DECREF" after having set it to NULL. (It mixes PY_XDECREF which is
>>> NULL safe with PY_DECREF which is not.)
>>> This just adds an explicit blacklist for all pyrex compilers < for that
>>> extension.
>>> One alternative is to set "have_pyrex = False" instead, and issue a note that
>>> we won't generate any of the .c files for old versions of pyrex.
>>> For now, this was the "minimal" change I could do.
>>> Thoughts?
>>> John
>>> =:->
>> Hey, I'm on Pyrex (Gutsy, yes I'm lazy) and don't have any
>> problems (aside from some compiler warnings). Why are you blacklisting it?
>> (OTOH, I've never *tested* btrees.. Hmm..)
> I can ratchet it back. I believe 0.9.5 works fine. Mostly I only know that
> is segfaulting with bzr.dev. I thought I'd play it safe, but I don't
> have to play it that safe.
> John
> =:->

FWIW, I just ran the test suite and it went well, so seems to
be safe.

Does Pyrex have a changelog? Maybe it will say when this was fixed. (Not
that I'm asking you to do more research.)

More information about the bazaar mailing list