[MERGE][BUG #276436] Simple fix to WT.open()

[Wouter van Heyst]

On Wed, Oct 01, 2008 at 08:59:54AM -0500, John Arbash Meinel wrote:
> Martin Pool wrote:
> > On Wed, Oct 1, 2008 at 6:32 AM, John Arbash Meinel
> > <john at arbash-meinel.com> wrote:
> >> This is just a simple fix to WT.open() and some associated tests. I
> >> added them to bzrlib.tests.test_workingtree.TestDefaultFormat, because I
> >> was surprised that there was no direct tests for the "TestWorkingTree"
> >> to test the static members.
> >>
> >> I had considered deprecating not passing an argument (as obviously it
> >> isn't being used), but I decided to keep it for now.
> > 
> > Actually I think the existence of these methods is a bit questionable:
> > they just loop back in to BzrDir which eventually calls back in to
> > WorkingTree.   So they're not adding much value in functionality, and
> > I think any arguable simplicity in the api is outweighed by the
> > potential confusion of having too many ways to do the same thing.
> > 
> > Of course that I'm still happy you stopped them failing in this case.
> 
> I personally use WT.open quite often in TIMEIT scripts or in interactive
> discourse.

As do I for interactive work with ipython, fwiw. 

Wouter van Heyst