[MERGE] (refreshed) pyrex iter-changes

Alexander Belchenko bialix at ukr.net
Thu Sep 25 23:55:43 BST 2008


John Arbash Meinel пишет:
> Robert Collins wrote:
>> Just updating this patch to resolve NEWS issues.
> 
>> -Rob
> 
> 
> I haven't thoroughly reviewed your code yet, but I went ahead and
> updated it so that it will compile using mingw32 (and I would assume
> Visual Studio 2003, but I don't have that to test.)
> 
> I'm also including the incremental change as a diff.
> 
> This is built on top of my earlier python-compat.h changes.
> 
> John
> =:->
> 

John, for what reasons you and Robert still continue to using ints instead of enums?

+# This is the Windows equivalent of ENOTDIR
+# It is defined in pywin32.winerror, but we don't want a strong dependency for
+# just an error code.
+# XXX: Perhaps we could get it from a windows header ?
+cdef int ERROR_PATH_NOT_FOUND
+ERROR_PATH_NOT_FOUND = 3
+cdef int ERROR_DIRECTORY
+ERROR_DIRECTORY = 267

I've provided better code already:

cdef enum:
	ERROR_PATH_NOT_FOUND = 3
	ERROR_DIRECTORY = 267




More information about the bazaar mailing list