[MERGE] Restore "bzr revert" on win32

John Arbash Meinel john at arbash-meinel.com
Thu Sep 25 23:06:24 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lukas's recent change to introduce "_get_one_revision_tree()" ends up
breaking a few cases on win32. The specific issue, is that it can return
"tree.basis_tree()" which is actually a good thing. However, the merge
code seems to be calling "base_tree.lock_read()" before it calls
"target_tree.lock_write()".

I realize a more complete fix needs to happen in the merge code, but
this fix is good anyway. It means that looking up the revision trees
will be cached, etc.

I would add a test case, but I'm pretty sure they are already failing.

Unless we can think of a good way to add a test case that will fail
reasonably under Linux so that this gets caught by the PQM.

(Note that I still have my "make locks exclusive on Linux branch" which
would do just that.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjcC2AACgkQJdeBCYSNAAOiwwCeITaPIAc7R0AY8nIlVsXl39x1
3LcAoKyDIawzadpwzBEIr2wz8KREdRqy
=JyZG
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: lock_write_revert.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20080925/38391ec6/attachment.diff 


More information about the bazaar mailing list