[MERGE][Trivial] invalid version tuple attempt to raise AssertionError fails with TypeError

[Lukáš Lalinský]

On Wed, Sep 24, 2008 at 5:56 AM, Aaron Bentley <aaron at aaronbentley.com> wrote:
> Mark Hammond wrote:
>> Shock Horror!  How Dare They!  It might be worth keeping in mind that we are
>> talking code owned by others here, so your policy isn't relevant.
>
> We are in a community.  Treating one another with respect helps that
> community grow. If the authors of Qbzr thinks that _get_trees_to_diff
> is a useful function, it would be really nice if they told us so.
> Making it public is good for other bzrlib users, and it's also good for
> them, because then they don't have to worry that one day it will
> suddenly break on them.

There is also another point of view, here are the two options I see:

 a) Somebody submits a patch to make it public, the function changes
=> QBzr needs to be fixed to support both versions
 b) Somebody submits a patch in the future, and this patch changes the
function => QBzr needs to be fixed to support both versions

As you can see, both cases have the same end result for QBzr, but case
b) requires much less effort *now*, which is more important if you
work on something in free time and want to spend as less time on it as
possible. And this is not counting the effort to actually submit the
patch to make it public. :)

Lukas