[MERGE] fast read-dir support for unix too

[Robert Collins]

On Tue, 2008-09-23 at 09:04 +1000, Robert Collins wrote:
> 
> > Also, things are quite broken for win32, I'm getting infinite
> > recursion 
> > in
> > "file_kind_from_stat_mode_thunk". You are missing this line:
> > +            file_kind_from_stat_mode = _file_kind_from_stat_mode
> > 
> > After you import the correct version from the _readdir_py.py module.
> > 
> > So we should probably should have test that it can fallback
> correctly.
> 
> Oh hmm. I'll look at a unit test for this.

I couldn't think how to do one cleanly, as the code will always find the
C module if it exists at all.

> > Oh, and you broke the _walkdirs_win32 code, because it was expecting
> > to 
> > grab
> > "formats" from osutils.py. This fixes it for me:
> > === modified file 'bzrlib/_walkdirs_win32.pyx'
> > ...
> > I also think it would be reasonable to rename the
> > "_walkdirs_win32.pyx" 
> > file to
> > something like "_readdir_win32_pyx.pyx" to fit the other naming.
> 
> will do.

I ended up not doing this - because I can't be sure I wouldn't break
things. Consider it bb:approved to do it though :P.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080924/abf7d766/attachment.pgp