[MERGE][Trivial] invalid version tuple attempt to raise AssertionError fails with TypeError

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark Hammond wrote:
>> Mark Hammond wrote:
>>> bzrtools:
>>>
>>>  from bzrlib import revision as _mod_revision
>> That is not an example of importing a private symbol.
> 
> Could you please clarify?  It has a leading underscore, which is a
> bright-red flag to my (and grep's ;) eyes...

The symbol being imported is bzrlib.revision.  _mod_revision is simply a
local name for it.

>> Anyhow, we want to provide a great API, and if you have to use a private 
>> symbol, we're failing at that.  Please help us make our API great.

> In response to a suggestion that I propose the API as being public, I
> pointed out that many more mature plugins don't use the symbol, so maybe its
> not that suitable for becoming public

Do you think a reasonable plugin would want to use it?

> and these plugins *do* use other
> private symbols,

In violation of our policy.

> and have done so for far longer than for my code has
> existed.

Old code tends to be worse code.

> I think I've done my duty :)

I think that it would have been easy to make the symbol public at the
same time as fixing the bug.  I didn't say you had a duty, I made a request.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFI2QtW0F+nu1YWqI0RAk+ZAJ9lJ25RPVskLlYJhI8uZ8gQgMD+FACcCImT
2zjOV9myfRF4lL6y8JCCnwc=
=wikl
-----END PGP SIGNATURE-----