[MERGE] add lock hooks
John Arbash Meinel
john at arbash-meinel.com
Tue Sep 23 15:39:19 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Pool wrote:
> On Thu, Sep 4, 2008 at 2:28 PM, Robert Collins
> <robertc at robertcollins.net> wrote:
>> Robert Collins has voted resubmit.
>> Status is now: Resubmit
>> Comment:
>> John, Martin has invented a new idiom for using Hooks, via his clone and
>> clear_hooks() methods. These are untested - so for my part, this is tweak()
>> - if we're going to invent a new approach, it should be tested. (The
>> difference is that rather than constructing a new PhysicalLockHooks
>> instance, he's reusing the existing one.
>
> As a matter of fact they were tested, in test_hooks.test_clone_and_clear.
>
> Anyhow, while I think the way hooks are handled is not quite right, I
> also think that having just this one be different is not good. Here
> is an update which, relative to bzr.dev:
>
> * Adds a Lock base class
> * Adds Lock.hooks
> * adds lock_acquired and lock_released within it
>
>
BB:approve
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkjY/5cACgkQJdeBCYSNAANvBQCfRF8VwlzFPRhanIEypuHXKYtQ
DSsAni/DU5W5COoSZ99PtrKa7RLse6oP
=Y0df
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list