[MERGE][Trivial] invalid version tuple attempt to raise AssertionError fails with TypeError
Aaron Bentley
aaron at aaronbentley.com
Tue Sep 23 15:37:37 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Mark Hammond wrote:
> bzrtools:
>
> from bzrlib import revision as _mod_revision
That is not an example of importing a private symbol.
> from bzrlib.diff import _patch_header_date (in a test)
I guess I'm more comfortable with using private methods in tests, since
the worst that can happen is a spurious test failure. But maybe we
shouldn't allow even that.
Anyhow, we want to provide a great API, and if you have to use a private
symbol, we're failing at that. Please help us make our API great.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFI2P8x0F+nu1YWqI0RAhM/AJ4lgAzTOWK2PcybZixQdwK/gY5rvgCeKTT6
E+kIgtLH7woCa3w4uz4xy3M=
=ChjP
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list