[MERGE] Test for bug #272444 (symlinks to Unicode file names)

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Clemente wrote:
> Hi, thanks for the tips.
> 
> Robert Collins <robertc at robertcollins.net> writes:
> 
>> Firstly, we try to put tests in files with related things, related by
>> the code they run rather than the concept.

Thanks for your patch.  It appears to supersede your original patch.
It's helpful if you base your changes on the original patch, so that
Bundle Buggy can automatically tell that the original patch has been
superseded.

I'll go manually mark it superseded.

>    There will be probably more tests on utf-8. But as you said, if Bazaar groups them by function checked instead of by concept, then instead of one TestUtf8.py there will be lots of tests for Utf-8, scattered around functions. That's ok.
> 
> 
>> So - bzrlib/tests/workingtree_implementations (soon to be
>> per_workingtree)/test_parents.py, which has a TestSetParents class.
>>
> 
>   I see very little relation between „parents“ and „utf-8 and symlinks“.

That is the last public method that in the traceback.  So that's a
method that is failing.

 My test has in addition a very different style from the other tests in
that file (it doesn't think about „parents“, it asserts, nothing, ...).
>   But for the practical reasons you explained, it may be useful to have it there. So I attach a second version of the patch with the test there.

Thanks, but I think the idea was to convert it into a test of
set_parent_trees, like the other ones there.

Also, we technically cannot merge a failing tests, because all tests
must pass in order for code to be merged.  We handle tests that are
expected to fail by raising KnownFailure, or use the helper method
TestCase.expectFailure.

bb:resubmit

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFI1/mu0F+nu1YWqI0RAlOKAJ9ZM31tY8/sTQJEG1xTqF1tV5HNcgCfcdRP
jc5oscogjrGPGF9SWOW908I=
=OppJ
-----END PGP SIGNATURE-----