[MERGE][Trivial] invalid version tuple attempt to raise AssertionError fails with TypeError

Aaron Bentley aaron at aaronbentley.com
Sat Sep 20 19:19:38 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark Hammond wrote:
> This is fairly trivial, but bzrlib._format_version_tuple() raises an
> unintended exception when passed an invalid version tuple (so I'm reusing
> that function even though it has an underscore - sue me ;)

Since you admit that you're using a private function in an extension,
you should propose turning it into a public function.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFI1T660F+nu1YWqI0RAj2LAJ9UWuHvQmSIW7BX7FFmtizgCiiSzACeKDKF
dXkThF2md0AqciJqwRhzCe0=
=LwZa
-----END PGP SIGNATURE-----



More information about the bazaar mailing list