[RFC] Change to use 'merge_sort' for per-file-log

Robert Collins robertc at robertcollins.net
Fri Sep 19 08:00:59 BST 2008


On Thu, 2008-09-18 at 22:49 -0500, John Arbash Meinel wrote:
> 
> Also, I have one more addendum, which works around issues with
> GraphIndex.get_parent_map(lots_of_keys). Basically, by requesting keys
> in 1000
> key "chunks", I avoid the "buffer_all" overhead, but also avoid some
> of the
> extra bisection overhead (especially for smaller indexes.)

I find it amusing that we're spinning on this :) - I did note that the
heuristic size was likely problematic when we brought this in.

Perhaps the heuristic just needs changing ?

I think its ok to do this change, as long as we come back to this and
make it more tunable in the near term - perhaps just by doing the
generation in-tune with the log iteration batching?

-Rob

bb:approve
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080919/baf8b01e/attachment.pgp 


More information about the bazaar mailing list