[MERGE/RFC] LocalTransport.abspath() should return a drive letter if the transport has one
Mark Hammond
mhammond at skippinet.com.au
Fri Sep 19 01:36:23 BST 2008
> On Thu, 2008-09-18 at 03:26 -0400, Ian Clatworthy wrote:
> > Ian Clatworthy has voted resubmit.
> > Status is now: Resubmit
> > Comment:
> > the test needs to be skipped on non-Windows platforms - breaks the
> > suite otherwise
>
> I disagree; this test should be able to be run on linux; and helps
> prevent regressions.
As discussed on IRC, the problem here is that osutils does platform specific
things at import time, so our attempts to change its behaviour by adjusting
sys.platform in the test are defeated. I've attached a new patch that skips
the test on non-windows platforms.
Thanks,
Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: local_transport_abspath.patch
Type: application/octet-stream
Size: 5644 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080919/55818af2/attachment.obj
More information about the bazaar
mailing list