[MERGE] Skip unnecessary work in BzrBranch._basic_push.

[Andrew Bennetts]

Andrew Bennetts wrote:
[...]
> 
> This improvement really deserves to be enforced with some of those effort tests
> I've been promising, but in the meantime here it is with no automated tests.

I know John already approved the patch, but I really do want to improve testing
of this sort of thing.  I've come to the conclusion that the best way to
introduce “effort” tests is to just adding them incrementally, and we can worry
about more elegant infrastructure and organisation for them when we have more
than a trivial number of them :)

So here's a new patch; the fix itself is unchanged, but this adds a simple
test_effort.py that ensures that both the Branch.push API and the cmd_push
builtin command do a limited number of RPCs.  I'm still unsure exactly how exact
to make the assertions for these tests... comments are welcome!  Probably
test_effort.py deserves some more helpful docstrings as well.

The patch also introduces (and uses) _SmartClient.hooks, which currently just
has a 'call' hook.

-Andrew.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: faster-empty-push.patch
Type: text/x-diff
Size: 14052 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080915/591a7bbf/attachment.bin