[MERGE][1.7] Fix '_in_buffer' AttributeError when using the -Dhpss debug flag.

John Arbash Meinel john at arbash-meinel.com
Thu Sep 11 21:58:14 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> Hi,
> 
> When bzrlib/smart/protocol.py was changed to reduce string concatenations for
> 1.6, one use of the old “_in_buffer” attribute of ProtocolThreeDecoder inside a
> -Dhpss code path wasn't changed.
> 
> This trivial patch updates that spot, and for good measure removes a commented
> out line of code that referenced that attribute too.  I checked for other uses
> with grep, and didn't find any other uses.
> 
> This patch is very small and safe, and helps debugging with -Dhpss, so I think
> it's worth cherry-picking into 1.7.
> 
> -Andrew.
> 
> 

BB:approve

For bzr.dev and for 1.7.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjJhmYACgkQJdeBCYSNAAMB9QCeLmObNoS9YGX/t9XZ8IR6Q8lP
0d8AoJZ0bVtmIqI1Whk8vKJ7NoumES77
=wJo5
-----END PGP SIGNATURE-----



More information about the bazaar mailing list