[MERGE] Only loop graph.iter_ancestry once when running "bzr log FILE"
Aaron Bentley
aaron at aaronbentley.com
Tue Sep 9 15:08:05 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> Also, Graph instances will have their own cache via
>> CachingParentsProvider, and that will not expire for the lifetime of the
>> Graph.
>
> Well, actually Repository.get_graph() injects the
> CachingParentsProvider,
Yes, I know. I wrote that.
> which is something I'd really like to get rid
> of. We do it mostly because of poor performance in GraphIndex caching.
> So with BTree we will likely be fully away from it.
I don't know. Nothing expires from a CachingParentsProvider, and I
thought that was a win, because it guarantees maximum performance of
subsequent operations on that Graph.
> Mostly, I was just planning on waiting for BTree indexes to be
> available, and having BTreeRepository.get_graph() not inject a
> CachingParentsProvider.
I would *love* to have a performant index again. As you noticed, it's
one of the things killing tree-building performance.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFIxoNF0F+nu1YWqI0RAmSoAJ94Qn7iSiZCj/nF61Te80WUEgdbnACffClj
uyf+FvbAvkSHUK3lODPfEUo=
=+gNJ
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list