[MERGE] Refactor bzrlib.osutils._walkdirs_utf8 to aid API migration in future.
John Arbash Meinel
john at arbash-meinel.com
Tue Sep 9 15:05:07 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert Collins wrote:
> This patch refactors the guts of _walkdirs_utf8 to be more modular.
>
> In my testing its no slower than trunk (3ms, the expected overhead of a
> call-per-dir on mozilla trees is below noise level). I believe my
> changes to the win32 walker are correct - that is that the win32 feature
> tests will pass and it will run well on win32; I would appreciate a
> win32 developer (two are cc'd to this) confirming that this is the case
> before I submit it to PQM [assuming it gets through review].
>
> Cheers,
> Rob
>
Just a quick note, the test__walkdirs_win32.py tests are broken at the
moment. With this patch. Probably easy to fix, and I'll give it a shot.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkjGgpMACgkQJdeBCYSNAAPHhACgqgZIn+NK57yTO6/Hlewyi2p0
xTAAnRTv8Y+oAZgrA1Zpq+fGlsCChElA
=HAeh
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list