[MERGE] Add tests for commit_message_template hooks.

Jelmer Vernooij jelmer at samba.org
Sat Sep 6 05:04:59 BST 2008


Am Mittwoch, den 03.09.2008, 14:59 -0400 schrieb John Arbash Meinel:
> John Arbash Meinel has voted resubmit.
> Status is now: Resubmit
> Comment:
> This should wait until 1.8.
> Otherwise I'm okay with this. Obviously it needs a NEWS entry, possibly 
> an update under doc/* and there is a string that says "new in 1.7" that 
> should be updated.
Thanks for the review. I've fixed these issues in the attached patch.

> Also, I think we need an end-to-end commit check, that the default 
> commit message is supplied at the right time. (Basically that 
> generate_commit_message_template() will be called by the commit logic.)
What would be the most appropriate place to test this? The blackbox
tests, or test_commit or test_msgeditor? 

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: commit-message-template-hook.diff
Type: text/x-patch
Size: 10238 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080906/7f9a170c/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080906/7f9a170c/attachment.pgp 


More information about the bazaar mailing list