[MERGE][1.7] Trivial fix for sftp readv
John Arbash Meinel
john at arbash-meinel.com
Thu Sep 4 03:46:49 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
I've been working on a minor overhaul of SFTPTransport.readv() and I came
across this very interesting bug.
Basically, it turns out that you can extend a list with a string using this
>>> x = 
>>> x += 'foo'
['f', 'o', 'o']
This code dates back to revno 1800, or so. I'm pretty amazed it has been there
for so long.
Anyway, with this patch, 'bzr branch sftp://localhost/...' drops from 37s =>
~30s. And I imagine it is even better when dealing with bigger branches.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2664 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080903/81ae798a/attachment-0001.bin
More information about the bazaar