[MERGE] [#165014] Support IPv6 in smart server
andrew at canonical.com
Wed Sep 3 00:17:40 BST 2008
Andrew Bennetts has voted tweak.
Status is now: Conditionally approved
This looks ok to me, but I wonder if it works on all platforms?
Specifically, I'm not sure that using None rather than '0.0.0.0' as the
host for sock.bind((host, port)) is cross-platform? The Python 2.4 docs
say host can be an IP address or domain name, but doesn't mention None.
Also, I'm not sure if we can always expect constants like AF_UNSPEC and
AI_ADDRCONFIG to be available on all platforms?
Basically, if this works on Windows, I'm happy. So the "tweak" I'm
asking for is confirmation that someone has tried this patch on Windows.
For details, see:
More information about the bazaar