[MERGE] Deprecate Repository.revision_tree(None) (updated)

John Arbash Meinel john at arbash-meinel.com
Tue Sep 2 19:55:44 BST 2008


John Arbash Meinel has voted approve.
Status is now: Approved
Comment:
=== modified file 
'bzrlib/tests/repository_implementations/test_repository.py'
--- bzrlib/tests/repository_implementations/test_repository.py 
2008-08-18 23:11:59 +0000
+++ bzrlib/tests/repository_implementations/test_repository.py 
2008-09-01 15:52:24 +0000
@@ -335,7 +335,9 @@
          expected.revision = 'revision-1'
          self.assertEqual([('', 'V', 'directory', 'fixed-root', 
expected)],
                           list(tree.list_files(include_root=True)))
-        tree = wt.branch.repository.revision_tree(None)
+        tree = self.callDeprecated(['NULL_REVISION should be used for 
the null'
+            ' revision instead of None, as of bzr 0.91.'],
+            wt.branch.repository.revision_tree, None)

^- I would have probably preferred to see this as a separate focused 
test, but it isn't a big deal.

At least we are testing that it a) does still work and b) is deprecated

For details, see: 
http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C20080902003133.GA29167%40vernstok.nl%3E
Project: Bazaar



More information about the bazaar mailing list