[MERGE] Fix PreviewTree.paths2ids

John Arbash Meinel john at arbash-meinel.com
Fri Aug 29 16:37:32 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Hi all,
> 
> This patch improves the testing of Tree.paths2ids, and changes
> PreviewTree to use the standard paths2ids implementation.
> 
> Aaron

As you are adding an implementation of "has_id" I was thinking you should
probably add a PreviewTree specific test for it to ensure that if a file was
"added" or "removed" as part of the merge, that "has_id" properly notices.
(Assuming the rest of has_id is properly tests as part of the
tree_implementations tests.)

Otherwise,
BB:tweak

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIuBe8JdeBCYSNAAMRAmyjAJ9uONd8/op8jTlPFZTcDZsMDp2OwgCgw2zl
1LsOiY67yTzsWccYPcHWKac=
=T+je
-----END PGP SIGNATURE-----



More information about the bazaar mailing list