[MERGE] Obey --quiet on select builtins (fixes 239523)

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Neil Martinsen-Burrell wrote:
> Bug #239523 notes that bzr tag --quiet blah is not quiet.  The reason is
> that many of the commands in builtins.py use self.outf.write() to give
> user feedback and take no account of the global trace.is_quiet() state. 
> In trying to fix this, I've tried to get away from every command having
> to check is_quiet when they want to give feedback.  To do that I added a
> method on Command objects called mention() that checks is_quiet
> appropriately before it writes to self.outf.

is_quiet should only silence optional text.
optional text should only be emitted to stderr

We already have trace.note for this.  I have already asked you to use
trace.note.  You don't provide any justification for not using it.

Your previous effort was almost perfect-- in fact, I approved it.  I
don't understand why you're rewriting from scratch here.

bb:reject

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFItMlT0F+nu1YWqI0RAufrAJwL+yl6mDjpsHHGMsC2p/XkHhDUxgCdEbSn
LT9y645lm3wZIiPsJ50Hc8g=
=Fn5q
-----END PGP SIGNATURE-----